redbeardymcgee/podbox
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

added quadlets for foundryvtt, netboot.xyz and joplin #1

Merged
sudo-kraken merged 1 commit from feature/additional-quadlets into main 2024-12-04 14:49:23 +00:00
Conversation 12 Commits 1 Files changed 10 +147
sudo-kraken commented 2024-12-03 17:45:43 +00:00 (Migrated from github.com)
Copy link
No description provided.
redbeardymcgee (Migrated from github.com) reviewed 2024-12-03 17:45:43 +00:00
quadlets/foundryvtt/foundryvtt.container
@ -0,0 +21,4 @@
Volume=./foundryvtt:/data:z
#Volume=foundryvtt-data:/data
Network=foundryvtt.network
redbeardymcgee (Migrated from github.com) commented 2024-12-04 02:21:28 +00:00
Copy link

I still need to confirm if these Network=... are totally necessary. I have another user who can't seem to access containers at localhost:9000 but I'm still debugging why with them.

I still need to confirm if these `Network=...` are totally necessary. I have another user who can't seem to access containers at `localhost:9000` but I'm still debugging why with them.
sudo-kraken commented 2024-12-03 17:46:24 +00:00 (Migrated from github.com)
Copy link

let me know if this is ok and I will create some more of services I run, these are current working ones that I am using in this PR.

let me know if this is ok and I will create some more of services I run, these are current working ones that I am using in this PR.
redbeardymcgee commented 2024-12-04 00:35:38 +00:00 (Migrated from github.com)
Copy link

Hey @sudo-kraken thanks a lot! Upon initial review, these seem great. I'll double check them again soon.

I'd love to see more of your quadlet definitions as well. The only thing I want to ask is that you try to limit the MR to a single quadlet in the future. No worries on this one though, especially since the commit history on this repo is not particularly clean yet. I have been trying to do better!

Hey @sudo-kraken thanks a lot! Upon initial review, these seem great. I'll double check them again soon. I'd love to see more of your quadlet definitions as well. The only thing I want to ask is that you try to limit the MR to a single quadlet in the future. No worries on this one though, especially since the commit history on this repo is not particularly clean yet. I have been trying to do better!
👍 1
redbeardymcgee (Migrated from github.com) reviewed 2024-12-04 02:11:53 +00:00
quadlets/foundryvtt/foundryvtt.container
@ -0,0 +1,36 @@
[Unit]
Description=Foundry VTT Quadlet
Wants=network-online.target
redbeardymcgee (Migrated from github.com) commented 2024-12-04 02:11:53 +00:00
Copy link

User services can't see system services, so network-online.target and local-fs.target are actually just ignored. Quadlets include a workaround using another service to provide this target. It's on by default, and to disable you must set DefaultDependencies=false

User services can't see system services, so `network-online.target` and `local-fs.target` are actually just ignored. Quadlets include a workaround using another service to provide this target. It's on by default, and to disable you must set `DefaultDependencies=false`
redbeardymcgee (Migrated from github.com) reviewed 2024-12-04 02:14:18 +00:00
redbeardymcgee (Migrated from github.com) reviewed 2024-12-04 02:18:56 +00:00
quadlets/foundryvtt/foundryvtt.container
@ -0,0 +18,4 @@
#AutoUpdate=registry
# Set this instead to expose it locally for asset uploads etc
Volume=./foundryvtt:/data:z
redbeardymcgee (Migrated from github.com) commented 2024-12-04 02:18:56 +00:00
Copy link

Named volumes are located at ~/.local/share/containers/storage/volumes/<volume>/ with a _data directory inside. I think named volumes need better documentation and exposure, but you don't need to mount ./foundryvtt:/data. You can use the named volume location to drop in assets just the same. I am trying to default to named volumes for this repository because foo.volume does the mkdir for the user. Feedback for a missing path is not great for quadlets (it's in the system journal) and will cause a failure to launch, so forgetting to run mkdir foundryvtt can lead to frustration.

Named volumes are located at `~/.local/share/containers/storage/volumes/<volume>/` with a `_data` directory inside. I think named volumes need better documentation and exposure, but you don't need to mount `./foundryvtt:/data`. You can use the named volume location to drop in assets just the same. I am trying to default to named volumes for this repository because `foo.volume` does the `mkdir` for the user. Feedback for a missing path is not great for quadlets (it's in the system journal) and will cause a failure to launch, so forgetting to run `mkdir foundryvtt` can lead to frustration.
redbeardymcgee commented 2024-12-04 02:23:34 +00:00 (Migrated from github.com)
Copy link

Had some dinner and dropped in some comments. These are actually notes for ME, and you are not expected to make any changes to your merge request unless you feel like it. I just thought it would be useful for anyone to see.

Will merge upon your approval.

Had some dinner and dropped in some comments. These are actually notes for ME, and you are not expected to make any changes to your merge request unless you feel like it. I just thought it would be useful for anyone to see. Will merge upon your approval.
sudo-kraken commented 2024-12-04 06:05:38 +00:00 (Migrated from github.com)
Copy link

Perfect, the comments are actually very useful for me too! Happy for you to merge and update.

Perfect, the comments are actually very useful for me too! Happy for you to merge and update.
sudo-kraken (Migrated from github.com) reviewed 2024-12-04 07:37:26 +00:00
sudo-kraken commented 2024-12-04 07:44:43 +00:00 (Migrated from github.com)
Copy link

@sudo-kraken:matrix.krakensarchive.com add me on matrix if you have it, so we can discuss other changes etc essily without having to raise issues etc 😃.

[@sudo-kraken:matrix.krakensarchive.com](https://matrix.to/#/@sudo-kraken:matrix.krakensarchive.com) add me on matrix if you have it, so we can discuss other changes etc essily without having to raise issues etc 😃.
redbeardymcgee commented 2024-12-04 14:49:08 +00:00 (Migrated from github.com)
Copy link

I am looking into getting on Matrix someday, but not today. What I need to do is write a CONTRIBUTING.md document that includes a "style guide" of sorts, but I'm also not sure that the style I'm using currently is the final form.

Thanks for these too! Looking forward to seeing what other services you have running.

I am looking into getting on Matrix someday, but not today. What I need to do is write a `CONTRIBUTING.md` document that includes a "style guide" of sorts, but I'm also not sure that the style I'm using currently is the final form. Thanks for these too! Looking forward to seeing what other services you have running.
sudo-kraken commented 2024-12-04 14:53:40 +00:00 (Migrated from github.com)
Copy link

is it from now on 1 pr per service, ive reworked all my services to fit the format of yours

is it from now on 1 pr per service, ive reworked all my services to fit the format of yours
🚀 1
redbeardymcgee commented 2024-12-04 14:57:17 +00:00 (Migrated from github.com)
Copy link

github has done something inexplicable, and I cannot figure out how or why it happened. Your merge vanished.

I'll re-add them manually I guess, but I have no idea what happened. Do you see the files in the repo after the merge?

github has done something inexplicable, and I cannot figure out how or why it happened. Your merge vanished. I'll re-add them manually I guess, but I have no idea what happened. Do you see the files in the repo after the merge?
sudo-kraken commented 2024-12-04 14:57:30 +00:00 (Migrated from github.com)
Copy link

maybe create a discussion page so we can have back and forth to discuss some services as some services I have run multiple containers as dependancies ?

maybe create a discussion page so we can have back and forth to discuss some services as some services I have run multiple containers as dependancies ?
sudo-kraken commented 2024-12-04 14:57:50 +00:00 (Migrated from github.com)
Copy link

github has done something inexplicable, and I cannot figure out how or why it happened. Your merge vanished.

I'll re-add them manually I guess, but I have no idea what happened. Do you see the files in the repo after the merge?

I cant see them but I can re submit them with all the proper syntax etc

> github has done something inexplicable, and I cannot figure out how or why it happened. Your merge vanished. > > I'll re-add them manually I guess, but I have no idea what happened. Do you see the files in the repo after the merge? I cant see them but I can re submit them with all the proper syntax etc
sudo-kraken commented 2024-12-04 14:58:30 +00:00 (Migrated from github.com)
Copy link

I think it commited it on another branch that has been removed

I think it commited it on another branch that has been removed
redbeardymcgee commented 2024-12-04 15:22:17 +00:00 (Migrated from github.com)
Copy link

This one is already "merged" and I don't think I can "unmerge" and redo from this PR. You'll see in #2 that the revert also made zero changes. Something is not working right on gh loll

maybe create a discussion page so we can have back and forth to discuss some services as some services I have run multiple containers as dependancies ?

I can add this I think.

This one is already "merged" and I don't think I can "unmerge" and redo from this PR. You'll see in #2 that the revert also made zero changes. Something is not working right on gh loll > maybe create a discussion page so we can have back and forth to discuss some services as some services I have run multiple containers as dependancies ? I can add this I think.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: redbeardymcgee/podbox#1
No description provided.
Delete branch "feature/additional-quadlets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?