Added FoundryVTT Quadlet #3

Closed

sudo-kraken wants to merge 2 commits from features/foundryvtt into main

sudo-kraken commented

2024-12-04 15:22:16 +00:00

(Migrated from github.com)

No description provided.

redbeardymcgee (Migrated from github.com) reviewed 2024-12-04 15:22:16 +00:00

foundryvtt/foundryvtt.container

redbeardymcgee (Migrated from github.com) commented

2024-12-04 15:29:37 +00:00

I've been setting these to on-failure. My understanding is the value always would restart a container that exits with a success status code, which I think is undesirable. In Foundry this won't matter, because the container isn't supposed to exit at all.

What do you think?

I've been setting these to `on-failure`. My understanding is the value `always` would restart a container that exits with a success status code, which I think is undesirable. In `Foundry` this won't matter, because the container isn't supposed to exit at all. What do you think?

redbeardymcgee (Migrated from github.com) commented

2024-12-04 15:32:38 +00:00

I've been wondering about how to do these best. Some containers have a lot of env vars to configure, and I think we want to demonstrate best practices with EnvironmentFile=foundryvtt.env for example. Unfortunately, I think we can't pass secrets into foo.env like we can with Secret=secret-password,type=env,target=MY_ENV_VAR.

I'm not sure how to handle this best yet. Do you have any suggestions? Maybe I should keep it simple and just leave the .env files out of the repo?

I've been wondering about how to do these best. Some containers have a lot of env vars to configure, and I think we want to demonstrate best practices with `EnvironmentFile=foundryvtt.env` for example. Unfortunately, I think we can't pass `secrets` into `foo.env` like we can with `Secret=secret-password,type=env,target=MY_ENV_VAR`. I'm not sure how to handle this best yet. Do you have any suggestions? Maybe I should keep it simple and just leave the .env files out of the repo?